Add Eq(1) and Ord(1) instances for the free applicative

ekmett / free

free monads

http://hackage.haskell.org/package/free

Other

159 stars 65 forks source link

Add Eq(1) and Ord(1) instances for the free applicative #220

Closed viercc closed 1 year ago

viercc commented 1 year ago

This adds instances of Eq, Ord, Eq1, Ord1 instances to Control.Applicative.Free.Ap. Might want to look out for:

Instance for the older Eq1 class, defined in terms of eq1 :: Eq a => f a -> f a -> Bool, is hacky.
It adds some utility functions to Data.Functor.Classes.Compat. If this is an undesirable place to add these functions, I'll move them somewhere.

viercc commented 1 year ago

Thank you for the review. I've tried to explain everything and added lots of comments here, but I'm not sure it is an appropriate amount for the comment. I welcome any suggestions.