search

ekmett / machines

Networks of composable stream transducers
Other
339 stars 46 forks source link

Add MooreT module #106

Closed bens closed 4 years ago

bens commented 5 years ago

Any more suggestions for instances or functions would be appreciated.

bens commented 5 years ago

Bump?

YoEight commented 5 years ago

Sorry for the delay, I didn't see the first notification.

YoEight commented 5 years ago

LGTM. On a different note, is it still relevant to be overly aggressive with inlining? I mean, most of the time, GHC does a great job in this regard. Your code might need some updates in a few places though, as GHC requires a function to be fully applied to be a candidate for inlining.

bens commented 5 years ago

Perhaps not worthwhile, I haven't looked at any core, I was more following the example of the other modules. I'll check for partial applications, thanks.