search

ekmett / machines

Networks of composable stream transducers
Other
339 stars 46 forks source link

Profunctor Instance for MealyT #86

Closed sordina closed 7 years ago

sordina commented 7 years ago

Just like the title says. I've included CPP as per the Mealy Profunctor instance.

Let me know if there are any issues with this.

YoEight commented 7 years ago

Thanks for your work!

I have questions though. Why there are 2 identical commit messages Profunctor instance ?

I don't understand what is the point of the 3rd commit. It seems you wanted to rebase from ekmett/machines/master branch not merging it.

sordina commented 7 years ago

@YoEight My mistake, I forgot the --rebase flag when I pulled. Should be rebased now.

YoEight commented 7 years ago

Indeed but I think something went wrong in the process again. We should only see a single commit in this case.

sordina commented 7 years ago

Something went horribly wrong with rebase -i... This looks better.

YoEight commented 7 years ago

Thanks again for your work !

sordina commented 7 years ago

Cheers @YoEight. Would repeating the same work for a MooreT be a good use of time by the way?

YoEight commented 7 years ago

That's a weird question, why not doing what you want to do :-) ?

sordina commented 7 years ago

Haha, well I don't really have any need for it myself at the moment, but I'm feeling helpful, so what I want to do is influenced by what would be useful :)

YoEight commented 7 years ago

Do whatever you want, trust me it'll be useful if you take pleasure doing it :-)

sordina commented 7 years ago

How postmodern!