ekmett / parsers

Generic parser combinators
Other
88 stars 38 forks source link

More flags to parametrise generation #74

Closed phadej closed 6 years ago

RyanGlScott commented 6 years ago

It looks like the only remaining build failures are suggestions from a newer version of hlint.

The "Use String" suggestion is probably not warranted for this package, so I'd add ignore "Use String" to HLint.hs.

I'm not sure I understand what the "Reduce duplication" suggestions mean.

phadej commented 6 years ago

there are code paths which looks suspiciously similar, sometimes those are valid suggestions, sometimes they aren't.

phadej commented 6 years ago

i.e I'd just ignore them too, can I?

RyanGlScott commented 6 years ago

I'd be fine with ignoring that suggestion as well, sure.

phadej commented 6 years ago

green.

RyanGlScott commented 6 years ago

Thanks, @phadej!