search

ekmett / profunctors

Haskell 98 Profunctors
http://hackage.haskell.org/package/profunctors
Other
70 stars 43 forks source link

Rename new Traversing functions #52

Closed treeowl closed 7 years ago

treeowl commented 7 years ago

Since the new dimapTraversing, etc., are only good definitions of dimap, etc., for instances defining an explicit wander, the names should reflect that, as dimapWandering, lmapWandering, and rmapWandering.

RyanGlScott commented 7 years ago

Seems reasonable. Can you put that disclaimer ("only good definitions of dimap, etc., for instances defining an explicit wander") in the Haddocks for each functions? Thanks!

treeowl commented 7 years ago

Done.

On Mon, Jul 10, 2017 at 12:28 PM, Ryan Scott notifications@github.com wrote:

Seems reasonable. Can you put that disclaimer ("only good definitions of dimap, etc., for instances defining an explicit wander") in the Haddocks for each functions? Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ekmett/profunctors/pull/52#issuecomment-314159896, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzi_XuaJG1H1wE1yMEyOBGMNyPWC1aRks5sMlEvgaJpZM4M_sFg .