search

ekmett / profunctors

Haskell 98 Profunctors
http://hackage.haskell.org/package/profunctors
Other
70 stars 43 forks source link

Mapping Kleisli on old GHC #76

Closed treeowl closed 5 years ago

treeowl commented 5 years ago

Write a custom implementation of roam for Kleisli m even on old GHC versions.

RyanGlScott commented 5 years ago

Possibly silly question: could we avoid the use of CPP if we used the WrappedMonad code path everywhere?

treeowl commented 5 years ago

I think so, but it's quite a wart. I used the CPP so the whole thing will vanish in a puff of cleanup whenever (if ever) GHC 7.8 moves out of the support window.

RyanGlScott commented 5 years ago

OK. In that case, could you leave a brief comment explaining why CPP is used here, and that it should be revisited in the future? Other than that, LGTM.

treeowl commented 5 years ago

Also, there's been at least some talk about eventually deprecating WrappedMonad, now that Monad of no return is in progress.

treeowl commented 5 years ago

@RyanGlScott Done!