Closed treeowl closed 5 years ago
Possibly silly question: could we avoid the use of CPP if we used the WrappedMonad
code path everywhere?
I think so, but it's quite a wart. I used the CPP so the whole thing will vanish in a puff of cleanup whenever (if ever) GHC 7.8 moves out of the support window.
OK. In that case, could you leave a brief comment explaining why CPP is used here, and that it should be revisited in the future? Other than that, LGTM.
Also, there's been at least some talk about eventually deprecating WrappedMonad
, now that Monad of no return is in progress.
@RyanGlScott Done!
Write a custom implementation of
roam
forKleisli m
even on old GHC versions.