search

ekmett / profunctors

Haskell 98 Profunctors
http://hackage.haskell.org/package/profunctors
Other
70 stars 43 forks source link

Compatibility with transformers 0.6 #98

Closed sjakobi closed 3 years ago

sjakobi commented 3 years ago

https://hackage.haskell.org/package/transformers-0.6.0.0/changelog

Could you upload a compatible release or make a Hackage revision?

RyanGlScott commented 3 years ago

The following dependencies, which also impose an upper version bound of transformers < 0.6, will need to be addressed first:

sjakobi commented 3 years ago

I have opened https://github.com/haskell-opengl/StateVar/issues/10.

phadej commented 3 years ago

transformers-compat should be first on the list.

sjakobi commented 3 years ago

transformers-compat should be first on the list.

See https://github.com/ekmett/transformers-compat/issues/48.

RyanGlScott commented 3 years ago

I had a feeling that I had forgotten a dependency. I've added transformers-compat to the list in https://github.com/ekmett/profunctors/issues/98#issuecomment-882565028.

phadej commented 3 years ago

mtl is blocking my progress atm. Is it something @RyanGlScott can help with or who is maintaining that lib atm? 

[ 1 of 22] Compiling Control.Monad.Cont.Class ( Control/Monad/Cont/Class.hs, dist/build/Control/Monad/Cont/Class.o )

Control/Monad/Cont/Class.hs:58:1: error:
    Could not load module ‘Control.Monad.Trans.Error’
    It is a member of the hidden package ‘transformers-0.5.6.2’.

https://github.com/haskell/mtl/issues/88 + https://github.com/haskell/mtl/issues/86

EDIT: if mtl will have a major release (which seems unavoidable), it will cause a wrinkle in transformers-compat, but then the adoption of transformers-0.6 should be quite straightforward.

phadej commented 3 years ago

contravariant https://github.com/ekmett/contravariant/issues/68

Building library for contravariant-1.5.4..

old-src/Data/Functor/Contravariant.hs:69:8:
    Could not find module ‘Control.Monad.Trans.Error’
phadej commented 3 years ago 
allow-newer: bifunctors:transformers
allow-newer: bifunctors:transformers-compat
allow-newer: comonad:transformers
allow-newer: distributive:transformers

Seems to be safe to relax

RyanGlScott commented 3 years ago

I've pushed commits which raise the upper version bounds on transformers:

I've also made a corresponding Hackage revision to profunctors-5.6.2 here. I believe that takes care of everything, but do re-open this issue if I've forgotten something.