Closed johnkors closed 3 years ago
Note: this fix is only relevant for projects not using the Microsoft.NET.Sdk.Web
SDK.
dotnet publish
on a Microsoft.NET.Sdk
project targeting net3.1+, the old Microsoft.AspnetCore.Http.dll
v2.2.2 is present in the output folder.dotnet publish
on a Microsoft.NET.SDK
project having a FrameworkReference
to Microsoft.AspNetCore.App
, it won't be in the output folder.dotnet publish
on a Microsoft.NET.Sdk.Web
project it won't be present in the output folder. The Web SDK implicitly has FrameworkReference to Microsoft.AspNetCore.App
, meaning it will disregard the transient dependency from Serilog.Enrichers.CorrelationId, and use the framework version instead.
I guess there's nothing really stopping a non-web project from installing this package, but it's intended use case is around adding logs within a httpcontext. So I see now this PR might not be that relevant.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Closing due to lack of interest.
As pr https://github.com/dotnet/aspnetcore/issues/3756 ,
Microsoft.AspNetCore.Http
has been moved into the shared framework (installed via the runtimes) as of ASP.NET Core 3.0.This PR makes projects targeting netcoreapp3.1 or net5.0 avoid taking a transient dependency on the older Microsoft.AspNetCore.Http/2.2.2, but use the one newest from the shared framework version instead.