ekmsystems / serilog-enrichers-correlation-id

Enrich logs with a unique ID so you can track logs for specific requests.
MIT License
93 stars 38 forks source link

Updates dependencies for netcore 3.1 & net5.0 #86

Closed johnkors closed 3 years ago

johnkors commented 3 years ago

As pr https://github.com/dotnet/aspnetcore/issues/3756 , Microsoft.AspNetCore.Http has been moved into the shared framework (installed via the runtimes) as of ASP.NET Core 3.0.

This PR makes projects targeting netcoreapp3.1 or net5.0 avoid taking a transient dependency on the older Microsoft.AspNetCore.Http/2.2.2, but use the one newest from the shared framework version instead.

johnkors commented 3 years ago

Note: this fix is only relevant for projects not using the Microsoft.NET.Sdk.Web SDK.

The Web SDK implicitly has FrameworkReference to Microsoft.AspNetCore.App, meaning it will disregard the transient dependency from Serilog.Enrichers.CorrelationId, and use the framework version instead.

I guess there's nothing really stopping a non-web project from installing this package, but it's intended use case is around adding logs within a httpcontext. So I see now this PR might not be that relevant.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

johnkors commented 3 years ago

Closing due to lack of interest.