search

eknkc / ssr-benchmark

Benchmarking JS web framework SSR performance
745 stars 172 forks source link

add qwik and qwik-city #30

Closed PatrickJS closed 4 weeks ago

PatrickJS commented 4 weeks ago

everyone in Qwik should be using qwik-city (unless they're using astro+qwik). I added qwik to the renderers so devs can see the meta-framework overhead

Screenshot 2024-04-17 at 8 28 55 AM
eknkc commented 4 weeks ago

I fell like npm is screwing something up with these. There is obviously no issue in the PR but just checking out and trying to build after npm install results in this:

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.

Which is clear enough, I got everything cleaned up and re installed then there are missing dependencies with other modules for some reason. In partucular, next is failing spectacularly.

Installing with pnpm actually works fine without any issues whatsoever. But I'd def want the repo to work with npm by default. I've been away from my office and wanted to merge it on the go but I think I'll need to take a look tomorrow.

PatrickJS commented 4 weeks ago

oh yeah vite added a sharp dep that has weird platform deps let me include npm fixes

PatrickJS commented 4 weeks ago

ok @eknkc can you try again (and use latest node v20)