eknoes / golem-android-reader

An unofficial android application for german tech-site golem.de
https://play.google.com/store/apps/details?id=de.eknoes.inofficialgolem
GNU General Public License v3.0
20 stars 6 forks source link

Build APK in Github-Action #51

Closed Zusel closed 5 months ago

Zusel commented 6 months ago

Hey, I saw the issue and thought I would quickly fix it since I'm currently working a lot with GitHub Actions. Please squash the PR. The commits are a bit confusing. Here's what I've done:

I haven't forgotten the issue I wanted to work on. Unfortunately, I still don't have time for the big overhaul. Sorry.

fix: https://github.com/eknoes/golem-android-reader/issues/49

eknoes commented 6 months ago

Cool, thanks! Can you change it to only create releases when the commit is tagged or so? :)

Zusel commented 5 months ago

done :)

eknoes commented 5 months ago

Cool, danke! :) Noch eine kleine Sache die mir gerade aufgefallen ist: actions/create-release ist aktuell unmaintained. Meinst du, du kannst mit einer von den maintaineden Actions ersetzen? https://github.com/actions/create-release?tab=readme-ov-file#github-action---releases-api

Zusel commented 5 months ago

actions/create-release

Oh, ich bin davon ausgegangen das die Github eigenen Actions maintained werden. Bau ich natürlich um.

Zusel commented 5 months ago

So, habs ersetzt

eknoes commented 5 months ago

Danke!