search

eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities
http://vincent.composieux.fr
MIT License
141 stars 50 forks source link

Use dumper as service with new functs #33

Closed ScullWM closed 10 years ago

ScullWM commented 10 years ago

Hi Vincent,

I've use this great bundle in a project (thanks) and have some ideas for it, so I implement it :)

First: Dump of feed file is now a service, it's used for the cmd dump and it could be used where ever there's a ServiceContainer

I have love the possibility to generate feed from none entity model, it work very well, but I couldn't dump it with the console cmd: It need to have an entity with your "export" interface... I've set the entity as optionnal, and if you don't have set it, you could hydrate you feed directly with your own model :D

I've fix also a small issue that I get on my test server: dump feed with the cmd generate local's url... So, I look up how sonata sitemapBundle solve the problem and add a host arguments

This is my first "addon" on existing repo commit (not a typo fix), please be kind :rabbit:

eko commented 10 years ago

Hi @ScullWM,

Thank you for those great additions, I think it will be useful for a lot of developers using it!

However, can you please correct my little comments and add some PHPdoc (on class and methods) in FeedDumpService and unit tests please?

Thank you :+1: :)

ScullWM commented 10 years ago

Here are some improvement. Sorry, but there is no test (I'm not enough familiar with phpUnit to test output file and symfony service call...)

eko commented 10 years ago

@ScullWM Alright, thank you, I will have a look to add unit tests to this pull request as soon as possible (not sure to have enough time this week-end but it will comme soon) :)