eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities

http://vincent.composieux.fr

MIT License

141 stars 50 forks source link

Allow group item fields to be created from instances of regular ItemField #43

Closed dennisusdev closed 9 years ago

dennisusdev commented 9 years ago

42 allow attributes on GroupItemField

eko commented 9 years ago

@dennisusdev,

I don't think this is the best way to do that.

You can have a look on what I've just done here: https://github.com/eko/FeedBundle/commit/d3f8e7c4129f80a6a42e6c74cd1a30f8f04814a8

I think there is one more thing to add here: the possibility to specify a method name so we have to check if the method name exists, and if so just return the result. Else, specify the given value.

What do you think?

eko commented 9 years ago

Closing this PR as the issue is now closed. Thank you!