search

eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities
http://vincent.composieux.fr
MIT License
141 stars 50 forks source link

issue #11 #45

Closed jakon89 closed 9 years ago

jakon89 commented 9 years ago

Hi, I implemented idea from issue #11. All test passed: https://travis-ci.org/jakon89/FeedBundle Backwards compatibility is maintained.

I also added PHPUnit4 as composer dependency. It's much convenient to use with PHPstorm.

I look forward to your feedback.

eko commented 9 years ago

Hi @jakon89,

Thank you for working on this feature.

However, I've added some comments in order to keep a readable code.

Can you please fix them?

Thank you!

jakon89 commented 9 years ago

"Can you please fix them?" Yes, no problem.

I will fix this PR in this week. Thanks

jakon89 commented 9 years ago

Hi, Should be ok now :)

eko commented 9 years ago

One more thing, are you familiar with PHPunit's tests in order to add a unit test for the $feed->get('link') different cases?

If not, I will add it by myself later.

Thank you @jakon89

jakon89 commented 9 years ago

I don't know how to refactor test, would be great to see you in action :)

eko commented 9 years ago

Thank you @jakon89, I will add a unit test later.