search

eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities
http://vincent.composieux.fr
MIT License
141 stars 49 forks source link

Changed behavior of UrlGenerator to remove deprecations #54

Closed sebastianblum closed 8 years ago

sebastianblum commented 8 years ago

Hello,

With Symfony 2.8, the params of the UrlGeneratorInterface are changed. So i changed the param from true to UrlGeneratorInterface::ABSOLUTE_URL.

The new Constants are also included in Symfony 2.3, so it should work fine.

greetings from munich, Sebastian

eko commented 8 years ago

Hi @sebastianblum,

Indeed, thank you for this fix! Can you please squash your commits? We could merge then.

sebastianblum commented 8 years ago

so, now it should be fine. Thank you very much @eko

eko commented 8 years ago

Great, thanks :)

sebastianblum commented 8 years ago

do you know when you plan the next minor version on packages @eko ?

eko commented 8 years ago

@sebastianblum I just tagged 1.2.7 with your change.