search

eko / FeedBundle

A Symfony bundle to build RSS feeds from your entities
http://vincent.composieux.fr
MIT License
141 stars 49 forks source link

Fixed Warning: DOMDocument::createElement(): unterminated entity refe… #59

Closed claretcrab closed 8 years ago

claretcrab commented 8 years ago
Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR 
 public function getFeedItemRouteParameters()
    {
        return [
            'slug' => $this->getSlug(),
            'utm_source' =>'mysource',
            'utm_medium' =>'mymedium',
            'utm_campaign' =>'mycampaign',
            'utm_content' =>'mycontent'
        ];
    }

You get this error: Warning: DOMDocument::createElement(): unterminated entity reference utm_medium=mymedium&utm_campaign=mycampaign&utm_content=mycontent

eko commented 8 years ago

Hi @clarecrab,

Thank you for this fix. Can you please provide a little unit test to ensure special chars are transformed to html chars?

Thank you

claretcrab commented 8 years ago

Done! And thanks for sharing your bundle ;)

eko commented 8 years ago

Great, thank you @claretcrab :)