search

eko / docker-symfony

Run a Symfony application using Docker & docker-compose
BSD Zero Clause License
1.29k stars 475 forks source link

Some tools for the PHP container #142

Closed automatix closed 3 years ago

automatix commented 3 years ago

Hello @eko,

In the daily work it's comfortable to have following tools on the server / in the container:

Please be so kind and review & approve the PRs above. Thank you!

riwiki commented 3 years ago

Hi @automatix, hi @eko, I had a look at your PRs. Can I suggest a different approach? Instead of adding the tools directly to the php container, I usually add such tools to a dev container that extends the php container. Thereby, I keep the php container clean from tools and smaller for production. I haven't done a lot with docker-compose, but I liked that pattern the times I did. If it sounds interesting, I am happy to make a PR. Cheers

eko commented 3 years ago

Hi @riwiki,

I just merged the PR for adding the tools in the PHP container but I agree with you that this approach would be better. Feel free to submit a PR :-)

Thank you all

ricfio commented 3 years ago

Hi @riwiki, Hi @eko, I agree that using an external development container to install the various tools is a better approach ... so I look forward to the corresponding PR !

automatix commented 3 years ago

Hi guys!

@riwiki In principle I agree with you. My suggestion is just a quick solution.

@eko Thank you very much for the merges!

The ticket is resolved. I'm closing it.