search

eko / gocache

☔️ A complete Go cache library that brings you multiple ways of managing your caches
https://vincent.composieux.fr/article/i-wrote-gocache-a-complete-and-extensible-go-cache-library/
MIT License
2.46k stars 195 forks source link

update redis #153

Closed ashtonian closed 2 years ago

ashtonian commented 2 years ago

So v9 isn't quite ready. Is there another way to make this compatible without changing the dependency? I'd be willing to submit a PR but I don't know what the solution here is.

Could potentially make a simpler interface and then add v8/v9 adapters. Any thoughts ?

eko commented 2 years ago

Hello,

Thank you for proposing this v9 version.

While the v9 is not stable yet, I think we could split the redis store into 2 stores:

It seems that the interfaces will be the same at this time: no breaking change.

Once the v9 will be released stable, we will remove the v8 version and tag a new version of gocache. If people still want to use v8, they will be able to using older releases.

What do you think? Could you please update this PR?

Thanks

eko commented 2 years ago

Closing for now as there is no activity since 1 month. Please feel free to reopen if you really need it.

Anyway, we will switch to go-redis v9 as soon as it will be released as stable.