search

eko / gocache

☔️ A complete Go cache library that brings you multiple ways of managing your caches
https://vincent.composieux.fr/article/i-wrote-gocache-a-complete-and-extensible-go-cache-library/
MIT License
2.42k stars 192 forks source link

Bug or misunderstanding with applyOptionsWithDefault #168

Closed sgtsquiggs closed 1 year ago

sgtsquiggs commented 1 year ago

https://github.com/eko/gocache/blob/92c8ea6a1212ec80d72f920ced92455b69943d5f/store/options.go#L20-L28

This is incorrect, right? If my default options are "5 minute expiration" and then I set w/ a tag, I end up with the tag only and not tag plus expiration.