Closed rueian closed 1 year ago
Hello @rueian,
I agree with your proposals, if you want to open a PR you're mostly welcome, elsewhere I could find some time on next week to do these changes.
Thank you for this and to have built Rueidis :)
Thank you for this implementation.
Closing this PR for now but feel free to reopen if you still see anything that can be improved.
Hi @eko,
Thank you very much. Actually, I would also like to add an rueidis example to readme: https://github.com/eko/gocache/pull/189
Hi @eko, @rwrz,
Thank you for adding rueidis integration. It is my honor that rueidis can be integrated into this popular cache library.
Just wondering why doesn't Rueidis store implementation return a simple string instead of a
rueidis.RedisResult
? Are there some considerations I missed? I thought It would be much friendly if it returns a string to users like what go-redis integration does.For example:
Also, I noticed that there are some room for improvement:
setTags
can be manually pipelined:CacheTTL()
method this weekend. It can retrieve the remaining client-side TTL of a cached message. Then, theGetWithTTL
can be just like this:What do you think? I am happy to open a PR for the above changes. 😊