search

eko / gocache

☔️ A complete Go cache library that brings you multiple ways of managing your caches
https://vincent.composieux.fr/article/i-wrote-gocache-a-complete-and-extensible-go-cache-library/
MIT License
2.4k stars 193 forks source link

release request and doc updates to fix rediscluster v9 #214

Closed ashtonian closed 1 year ago

ashtonian commented 1 year ago

I think https://pkg.go.dev/ needs to be updated as it states v3 is the latest version.

Additionally could you do a release to enable redis v9 client ? right now using go get, it pulls v4.1.2 which doesn't include the change. I think the only way to access it then is to use go get with a commit hash off master I think that conflicts with the versioning (ie v4 in github.com/eko/gocache/lib/v4).

ashtonian commented 1 year ago

This only seems to be an issue with rediscluster as it seems redis/v4 has a newer tag published with the changes 4.2.0.

    github.com/eko/gocache/store/redis/v4 v4.2.0
    github.com/eko/gocache/store/rediscluster/v4 v4.1.2
ashtonian commented 1 year ago

I was able to fix that issue. I think the docs just need to be updated at pkg.go.dev to reflect v4.

eko commented 1 year ago

Hi @Ashtonian, you're right the package was not updated on pkg.go.dev for v4 branch.

I requested an update here: https://pkg.go.dev/github.com/eko/gocache/lib/v4 and it should be available as soon as the Golang bot will crawl the package ;-)

eko commented 1 year ago

Closing this issue as the documentation is now up-to-date on pkg.go.dev.

Thank you, feel free to reopen if you still have any issue!