search

eko / gocache

☔️ A complete Go cache library that brings you multiple ways of managing your caches
https://vincent.composieux.fr/article/i-wrote-gocache-a-complete-and-extensible-go-cache-library/
MIT License
2.4k stars 193 forks source link

Add GetWithTTL for chain cache #219

Closed BaptisteLemarcis closed 10 months ago

BaptisteLemarcis commented 1 year ago

Simply adding GetWithTTL on chain cache, we have it pretty much every where else and the TTL is already retrieved but not return by the Get method.

eko commented 1 year ago

Hi @BaptisteLemarcis,

Can you please explain why you don’t want to use Get() method?

Issue is that GetWithTTL is not implemented on each store, for instance Bigcache store does not implement it: https://github.com/eko/gocache/blob/cb0dccd38eabab63faa1f01331aab0015bbf10a5/store/bigcache/bigcache.go#L56

Thank you

eko commented 10 months ago

Closing as there is no activity.