eko / gocache

☔️ A complete Go cache library that brings you multiple ways of managing your caches
https://vincent.composieux.fr/article/i-wrote-gocache-a-complete-and-extensible-go-cache-library/
MIT License
2.4k stars 193 forks source link

fix(tests): replace golang mock by uber-go mock #249

Closed katsuharu closed 2 months ago

katsuharu commented 3 months ago

Hi there! 👋

I've created a pull request to address the issue https://github.com/eko/gocache/issues/248. In this PR, I've implemented the following changes:

Please review the changes and let me know if there's anything else needed or if further adjustments are required. Looking forward to your feedback!

Thank you!

eko commented 2 months ago

Could you please just rebase with the master branch? I've updated library to v4.1.6 on all stores so there is a conflict on go.mod now.

Thank you!

katsuharu commented 2 months ago

@eko Thank you for your review!

Sure, I’ll rebase with the master branch and resolve the conflict.

katsuharu commented 2 months ago

@eko Thank you for your feedback! I've rebased the changes as requested and pushed the updates to the PR. Please take another look at your earliest convenience.

eko commented 2 months ago

Thank you @katsuharu!