Add Porto

[That-Guy977]

Will resolve #1

Tasks:

• [x] Update README
• [ ] Add city screenshots
• [ ] Add location screenshots to collage
• [x] Extract city and route color
• [x] Generate city and route tiles
• [ ] Add location to map

[That-Guy977]

@ekohilas Should existing filenames and table entries be shifted to maintain alphabetical order within the cities?

[ekohilas]

@ekohilas Should existing filenames and table entries be shifted to maintain alphabetical order within the cities?

Uh, yeah.

I didn't really think they'd add another city when I made the map so there's gonna be a few things that'll need updating.

[That-Guy977]

So apparently generate_tiles removes r from city names in the generated image names in some specific circumstances? I have no idea what's up with that. It was fine after changing devices, since I couldn't get ImageMagick running on my main device.

[ekohilas]

Hmm that does sound weird… it’s been a while so I’ll have to take a look and get back to you.

On 25 Aug 2023, at 9:52 pm, That_Guy977 @.***> wrote:

 So apparently generate_tiles removes r from city names in the generated image names in some specific circumstances? I have no idea what's up with that. It was fine after changing devices, since I couldn't get ImageMagick running on my main device.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[That-Guy977]

The tiles I've managed to generate seem to not have the same binaries as the originals, and seems like the font isn't quite right. @ekohilas you might have to generate the tiles for this PR.

[ekohilas]

So apparently generate_tiles removes r from city names in the generated image names in some specific circumstances? I have no idea what's up with that. It was fine after changing devices, since I couldn't get ImageMagick running on my main device.

I have a feeling it's because of this sed command that is meant to remove trailing new lines, but is getting interpreted as an r on the system you're using.

I'm glad you were able to fix it by changing devices cause I can't think of a way off the top of my head to fix that :sweat_smile:

[ekohilas]

The tiles I've managed to generate seem to not have the same binaries as the originals

Yeah my bad. I think this has something to do with the fact that when the images are generated they're done so with a new timestamp and thus github sees them as a different image even though the binary is the same. I've created an issue (#6) that someone could pick up to fix this.

and seems like the font isn't quite right.

Also my bad, I used a font that was installed on my system called Liberation-Serif-Bold. I've created another issue (#8), but for now if you wanted to get it the same for yourself you could search for the font to download and install.

@ekohilas you might have to generate the tiles for this PR.

Can do, let me know when it's ready to do so.

[ekohilas]

Thank you for making these contributions, I really appreciate them!

When I created this I didn't really think that they'd create another city, and naively didn't plan ahead for what changes that would cause.

I may need to fix #7 so that it's not an issue with the current creation of the map, since all the references will change.

But don't let that stop you, keep it up and let me know where else I can help out :blush:!

[That-Guy977]

So apparently generate_tiles removes r from city names in the generated image names in some specific circumstances? I have no idea what's up with that. It was fine after changing devices, since I couldn't get ImageMagick running on my main device.

I have a feeling it's because of this sed command that is meant to remove trailing new lines, but is getting interpreted as an r on the system you're using.

I'm on macOS, so this may be a likely culprit. The other device was also macOS, but on a later version using zsh rather than bash, that may be the difference.

[That-Guy977]

and seems like the font isn't quite right.

Also my bad, I used a font that was installed on my system called Liberation-Serif-Bold. I've created another issue (#8), but for now if you wanted to get it the same for yourself you could search for the font to download and install.

I managed to find font files with matching names, but the output still isn't quite right (Regular is being loaded rather than Bold, if i had to guess). I'm not sure if it's just an issue of adding the fonts to ImageMagick, since I haven't used it before.

@ekohilas you might have to generate the tiles for this PR.

Can do, let me know when it's ready to do so.

I've committed data for Porto's color, connection color, and symbol, I think that should be enough data to generate the tiles?

[ekohilas]

I couldn't commit directly to your branch, so I made a PR.

[That-Guy977]

That's probably a mistake I made setting this PR up, I'll have to check that later (or just merge/cherrypick your commits on)

[That-Guy977]

I think I'll close this since we seem to be planning some structural changes to the repo, let's get v20 and v21 up after that

[ekohilas]

I think I'll close this since we seem to be planning some structural changes to the repo, let's get v20 and v21 up after that

No need to close, there's a lot of great content in here! We can still keep this open and rebase once those changes are done.

[That-Guy977]

I'll keep the branch up and rebase that probably, but I'm not so sure about working around the upcoming changes to the repo within the branch, since I'm not super proficient with git.

We'll get across that hurdle when it comes up, I suppose. I'm working on some other stuff for the time being.

[ekohilas]

Yeah don't worry about it, it's my fault so I can fix and incorporate your changes once it's up.