search

ekohilas / train-conductor-world-map

A set of files to generate a map for the Train Conductor World mobile game.
2 stars 1 forks source link

Add detailed location history #4

Closed That-Guy977 closed 1 year ago

That-Guy977 commented 1 year ago

Update 1.4 states that it adds 4 new locations, these are likely 4 of London, Edinburgh, Copenhagen, Gothenburg, Grimsby. If it's possible to figure out which 4, it may be beneficial to add that info to this list

ekohilas commented 1 year ago

The visual diff is still weird, but it's probably just a bug with Github. Let me know if there's anything else I missed! (Also I think you should be able to squash and merge after approval?

That-Guy977 commented 1 year ago

Seems like you've set a rule that only users with write access can merge pull requests, so you'll have to merge it yourself I suppose

ekohilas commented 1 year ago

Seems like you've set a rule that only users with write access can merge pull requests, so you'll have to merge it yourself I suppose

Thanks for letting me know! That seems to be a default rule that I couldn't find how to turn off. I'll merge it for now and then lookup how to disable.

That-Guy977 commented 1 year ago

Unresolved convo lol. Oh well