search

ekolis / FrEee

An open source clone of the classic 4X game Space Empires IV.
http://edkolis.com/freee
48 stars 12 forks source link

Somehow I can see my opponent's system flagged on the map #184

Open ekolis opened 3 years ago

ekolis commented 3 years ago

Describe the bug I encountered PvK's ships and now for some reason I can see his system marked on the map in his empire's color, even though it's unexplored.

To Reproduce See attached saves. speeech_29-30.zip

Expected behavior The system should not be marked with his color.

Actual behavior The system is marked with his color.

Screenshots image

Additional context See attached saves.

ekolis commented 3 years ago

When I opened our savegames for turn 30 in a text editor, I noticed that I had an order belonging to one of PvK's ships (order ID 308547177635881973, ship name Troubadour 2) somehow. I think he said that that ship was ordered to return to his home system? So it seems that ship orders are leaking to other players who can see the ship, and that's somehow causing the target system to light up on the map.

ekolis commented 3 years ago

Well, wait, Troubabour 2 wasn't even the ship I encountered...

ekolis commented 3 years ago

The ship was actually Lazarus 1, in the Xiban system.

I checked the ship-visibility code and it seems to be coming up as invisible to my empire, so I'm not sure why it's turning the map circle red...

Incidentally, loading PVK's game and selecting the ship froze the game for a bit; guess we need more pathfinding optimization!

ekolis commented 3 years ago

This might be related to #185.

ekolis commented 3 years ago

Hmm, now a different system is highlighted. I guess the ship moved? Must have something to do with that fleet it used to belong to...