reworked environments; updated docs; added features; changed version;

michaelkryukov commented 6 years ago

Description

Removed environments helpers and moved them into controllers.
Plugins now only have one local env variable (but can access eenv)
Changed extenv to eenv - executor's environment
Added args to on_startswith_text
Added more comments
Added tests
Increased coverage

Motivation and Context

Faster, easier to code, simpler to understand

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 61

131 of 147 (89.12%) changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 93.7%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kutana/controllers/dumping.py	4	5	80.0%
kutana/plugins/plugin.py	52	54	96.3%
kutana/controllers/vk/vk.py	23	27	85.19%
kutana/controllers/vk/vk_helpers.py	18	27	66.67%
<!--	Total:	131	147	89.12%	-->

Totals
Change from base Build 55:	1.2%
Covered Lines:	580
Relevant Lines:	619

💛 - Coveralls

michaelkryukov commented 6 years ago

This pull request introduces 1 alert and fixes 2 when merging 027ea231665aecdaf8a31229328dcdae5695f217 into 0ce944129533a4d0a07dc60b3a3c90557177b397 - view on LGTM.com

new alerts:

1 for Unused import

fixed alerts:

2 for 'import *' may pollute namespace

Comment posted by LGTM.com

michaelkryukov commented 6 years ago

This pull request fixes 2 alerts when merging d8492ebf789326c4e8aa69efcad20a9e07504c92 into 0ce944129533a4d0a07dc60b3a3c90557177b397 - view on LGTM.com

fixed alerts:

2 for 'import *' may pollute namespace

Comment posted by LGTM.com

ekonda / kutana