search

ekonomia-tech / protocol-alpha

Alpha version of a DeFi stablecoin protocol
GNU General Public License v3.0
4 stars 0 forks source link

Niv/photon kernel #51

Closed nmimran99 closed 2 years ago

nmimran99 commented 2 years ago

Photon Kernel PR Core changes:

  1. Kernel.sol - the kernel main contract that connects to PHO.sol and mints new $PHO
  2. IKernel.sol - Interface for Kernel.sol
  3. Minor changes accoss the protocol to make sure the contracts can be compiled
  4. Kernel.t.sol - tests for kernel

Notes:

forge test --match-contract KernelTest

nmimran99 commented 2 years ago

Tests will fail as core changes were made

kwhuo68 commented 2 years ago

Did another review here - decided to forgo small nits in favor of larger q's:

-Dispatcher is being consolidating with ModuleManager right? So that would affect a good chunk of PR -Kernel should have phoCeiling and setter? -Dispatcher delays -> moduleManager delays (are they necessary though)?

nmimran99 commented 2 years ago

Did another review here - decided to forgo small nits in favor of larger q's:

-Dispatcher is being consolidating with ModuleManager right? So that would affect a good chunk of PR -Kernel should have phoCeiling and setter? -Dispatcher delays -> moduleManager delays (are they necessary though)?