search

ekonomia-tech / protocol-alpha

Alpha version of a DeFi stablecoin protocol
GNU General Public License v3.0
4 stars 0 forks source link

add deploy scripts for ZCB and stablecoin deposit modules #69

Closed kwhuo68 closed 1 year ago

kwhuo68 commented 1 year ago

Core changes:

  1. Adds deploy script for ZCB module
  2. Adds deploy script for stablecoin deposit module
  3. Adds deploy script for Maple deposit module

Notes: First, populate values in Addresses.sol and then (with RPC_URL as mainnet fork) ->

  1. forge script scripts/DeployZCBModule.s.sol:DeployZCBModule --fork-url RPC_URL --broadcast
  2. forge script scripts/DeployStablecoinDepositModule.s.sol:DeployStablecoinDepositModule --fork-url http://localhost:8545 --broadcast
nmimran99 commented 1 year ago

one change which is a quick one - if the script has a hardcoded address for specific token, I think the token address should reside inside the script and the script name should include the name of the token

for example: DeployStablecoinDepositModule.s.sol -> DeployStablecoinDepositModule_USDC.s.sol

and instead of pushing usdcAddress into Addresses.sol, it should be inside the script because its used only by the script