Closed steve0xp closed 2 years ago
@davekaj Changes have been made, and responses given on some of the change requests you outlined. Please review at your leisure and once we are good with this PR then I can remove the Pool.sol
and comment out the associated test code while we coordinate the merging of Niv's Pool PR #6
Changes have been made, and comments acknowledged.
Primary Goals of PR
Write tests for
PIDController.sol
inPIDController.t.sol
:PIDController.sol
using foundryNOTES:
EUSDPools
andPIDController.sol
Pool.sol
will be deleted once draft PR is complete (after PR Review and Pools associated tests are checked through).Pool.sol
will be commented out. Then coordination will be required betweenPools
PR and this one.PIDController
files for now, but can move it based on people's thoughts.