[x] Implement into codebase so PHOGovernance and TONGovernance are set up properly
[ ] Run high-level tests (trusting the already audited code from compound) --> PHOGovernorBravoDelegator.t.sol && TONGovernorBravoDelegator.t.sol with BaseSetup.t.sol showcase the general process of pushing a proposal through && voting on it addModule() && setPHOCeiling()
Notes:
Discussed offline with @davekaj
This draft PR is very much in draft phase. Consider this moment just as a transition point between Dave and I.
Code compiles, but most of the delegateCalls fail if one looks at the traces when running the test using: forge test --match-contract TONGovernorBravoDelegator -vvvv && forge test --match-contract PHOGovernorBravoDelegator -vvvv
This draft PR was stalled due to misunderstanding of the proxy set up, I think it should be straight forward to unblock and get merged soon.
VOTE threshold values in delegate contracts were modified for both PHO and TON. Otherwise only a few lines were commented out or adjusted - simply search TODO within PHOGovernorBravoDelegate and TONGovernorBravoDelegate to see the latter
Primary Goals of PR
Core changes:
governorBravogovernance setupPHOGovernorBravoDelegator.t.sol&&TONGovernorBravoDelegator.t.solwithBaseSetup.t.solshowcase the general process of pushing a proposal through && voting on itaddModule()&&setPHOCeiling()Notes:
delegateCallsfail if one looks at the traces when running the test using:forge test --match-contract TONGovernorBravoDelegator -vvvv&&forge test --match-contract PHOGovernorBravoDelegator -vvvvdelegatecontracts were modified for both PHO and TON. Otherwise only a few lines were commented out or adjusted - simply searchTODOwithinPHOGovernorBravoDelegateandTONGovernorBravoDelegateto see the latter