Solve superious packet bug - Githubissues

ekr / minq

A simple Go implementation of QUIC

MIT License

98 stars 16 forks source link

Solve superious packet bug #36

Closed pietdevaere closed 6 years ago

pietdevaere commented 6 years ago

This PR fixes the following behaviour:

Consider a client sending a hello packet to an echo server.

client sends hello to server on stream 1
Server starts processing packet frame by frame
Server processes STREAM frame with hello on stream 1
Server calls StreamReadable(<stream 1>)
Server application handles the hello, and sends an echo
Server transmits echo packet
Server marks hello packet as received
Server transmits bare ack packet for hello packet

Commits:

e1bdbd2: make sure packets is fully processed before a new packet is transmitted
beb1d02: only flush queues if this has not already been caused by any of the StreamReadable() calls