Missing support of some java.time._ classes

ekrich / sjavatime

Implementation of java.time for Scala.js and Scala Native

BSD 3-Clause "New" or "Revised" License

14 stars 1 forks source link

Missing support of some java.time._ classes #7

Open plokhotnyuk opened 3 years ago

plokhotnyuk commented 3 years ago

I got linkage errors due missing of following classes when adding SN support for jsoniter-scala using this library (https://github.com/plokhotnyuk/jsoniter-scala/pull/640): java.time.ZonedDateTime$ java.time.LocalDateTime$ java.time.OffsetTime$ java.time.ZoneOffset$ java.time.OffsetDateTime$ java.time.ZoneId$ java.time.format.DateTimeFormatter$

https://github.com/plokhotnyuk/jsoniter-scala/pull/640/checks?check_run_id=1801112956#step:7:524

ekrich commented 3 years ago

@plokhotnyuk Thanks for the report.

sideeffffect commented 3 years ago

For ZIO, we would need

java.time.ZoneId.of(String zoneId)
java.time.OffsetDateTime.now()
java.time.OffsetDateTime.ofInstant(Instant instant, ZoneId zone)
java.time.temporal.TemporalAdjusters.firstDayOfNextMonth()
java.time.temporal.TemporalAdjusters.lastDayOfMonth()
java.time.ZoneOffset.ofTotalSeconds(int totalSeconds)
java.time.ZoneOffset.UTC

https://github.com/zio/zio/pull/4671

ekrich commented 3 years ago

@sideeffffect Thanks for the info.

plokhotnyuk commented 3 years ago

@ekrich Small and efficient implementation of .parse and .toString implementation for java.time._ types can be borrowed from here.

ekrich commented 3 years ago

Thank-you @plokhotnyuk. I will gladly take contributions if you or @sideeffffect have some cycles.