search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
137 stars 12 forks source link

feat: add tag support and tests for SageMakerDomain #111

Closed ekristen closed 7 months ago

ekristen commented 7 months ago

This adds tags for SageMakerDomain and also introduces mocks for SageMaker and unit tests for SageMakerDomain for the List and the Remove function.

Resolves #110

ekristen commented 7 months ago

@YuriGal let me know what OS you are on, I can provide a test build.

YuriGal commented 7 months ago

I run it in AWS CodeBuild, Linux.

ekristen commented 7 months ago

Builds are too big to upload here, finding another solution for providing intermediate builds.

ekristen commented 7 months ago

@YuriGal can you access this link? It contains all the binaries but the linux/amd64 is there -- should be able to test https://github.com/ekristen/aws-nuke/actions/runs/8196507179/artifacts/1307766418

YuriGal commented 7 months ago

Should be able to, need to reconfigure my setup a bit, but should be able to.

YuriGal commented 7 months ago

Sorry having issues doing it from CI environment, could you publish it as pre-release, so I can get it the regular way?

ekristen commented 7 months ago

:tada: This PR is included in version 3.0.0-beta.32 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ekristen commented 3 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: