search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
33 stars 6 forks source link

Filter properties are not respected #115

Closed YuriGal closed 4 months ago

YuriGal commented 4 months ago

Part of my filter is set like this

      EC2InternetGatewayAttachment:
      - property: "vpc:OwnerID"
        value: "123456789"
      EC2RouteTable:
      - property: "OwnerID"
        value: "123456789"
      EC2DHCPOption:
      - property: "OwnerID"
        type: "regex"
        value: "(123456789|987654321)"

The account has resources with Owner ID that match the filter. The original nuke had those filtered out. The fork still goes


us-west-2 - EC2InternetGatewayAttachment - igw-03be1339519e46fa9 -> vpc-0debf6fec89321668 - [DefaultVPC: "false"] - would remove
us-west-2 - EC2DHCPOption - dopt-0c578847d991d4df5 - [DefaultVPC: "false"] - would remove
us-west-2 - EC2RouteTable - rtb-0d7b4aa83ad8d4a37 - [DefaultVPC: "false", vpcID: "vpc-0debf6fec89321668"] - would remove

Would it be possible to have those filtered out? Not sure if there're other resources with the same issue, but these 3 definetely have it.

ekristen commented 4 months ago

I don't see property vpc:OwnerID or OwnerID on any of the output there. ~If you think the original aws-nuke works, can you show me the output?~

ekristen commented 4 months ago

I found the issue, looks like the original nuke was patched at some point and I missed it to add OwnerID, let me see if I can snag that.

ekristen commented 4 months ago

I'll have to spend some time comparing properties between the two and see what's different, not sure how I missed that. I'll fix it this evening, I can't do it right now. You'll get a notice here when it's fixed.

YuriGal commented 4 months ago

I really appreciate the effort you're putting into this. Thanks!

ekristen commented 4 months ago

Absolutely, I want the tool to be useful and easier to maintain and build, that's why I broke away.

ekristen commented 4 months ago

:tada: This issue has been resolved in version 3.0.0-beta.34 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ekristen commented 1 month ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: