search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
33 stars 6 forks source link

Merge Upstream PRs #135

Closed Petersoj closed 3 months ago

Petersoj commented 3 months ago

Thanks for your work on this fork and maintaining aws-nuke! I noticed that there are several PRs in the original project repo (like this one) that might be a good idea to merge (manually) into this fork. Any plans to do this?

ekristen commented 3 months ago

Yes absolutely. I usually review every couple of weeks and I have it semi-automated to pull it in. Looks like I hadn't seen that on.

I plan on jumping out of beta soon, I haven't found any new issues recently. Let me know if you do.

If you want to open an issue for a candidate PR to bring it to my attention that would be great. I'll look at pulling that one over. I try and keep commit history when possible, that one looks a little messy, so I might have to do some squashing, we'll see.

ekristen commented 3 months ago

:tada: This issue has been resolved in version 3.0.0-beta.40 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Petersoj commented 3 months ago

Wow that was insanely fast. You are a rockstar! Thanks!

ekristen commented 3 months ago

Please give it a go and let me know if you run into any issues. I didn't have any cloud front policies to directly test it against.

ekristen commented 3 months ago

Truthfully your issue caught me at a good time, I can't promise to always be this fast, but my goal is to not let things dwindle.

ekristen commented 3 months ago

@Petersoj I actually found 2 minor issues I need to fix, PR inbound shortly.

Petersoj commented 3 months ago

I will test it out soon! Thanks again. Edit: it's working great!

ekristen commented 1 month ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: