search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
137 stars 12 forks source link

feat: remove EC2 instances tags before termination #141

Closed Petersoj closed 5 months ago

Petersoj commented 5 months ago

PR for #138 with proper naming conventions and commit signing.

ekristen commented 5 months ago

hey @Petersoj thanks for the PR. I will review it here shortly. Sounds like I also need to write some docs up on opening a PR and how you can edit previous commits to format to semantic messages and sign, etc.

Petersoj commented 5 months ago

Well there is already some documentation in the contributing guidelines here about signing and commit message conventions, but I overlooked that guide on my first two PRs haha. I wish GitHub had a way to delete PRs...

ekristen commented 5 months ago

Confirmed working. I will write a test for it in a follow up PR later. I'm working on adding mock and integration tests so that real tests for some of the more important and complex resources can run in AWS.

ekristen commented 5 months ago

:tada: This PR is included in version 3.0.0-beta.42 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Petersoj commented 5 months ago

Awesome! Thanks for the fast release!

ekristen commented 5 months ago

That's part of my fork design, release faster with automation, not left to a human to cut a release.

ekristen commented 3 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: