search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
32 stars 6 forks source link

Add support for SageMaker Space Apps and Spaces #157

Closed npellegrin closed 2 months ago

npellegrin commented 2 months ago

In rebuy.de/aws-nuke the current SageMakerApp implementation doesn't support deleting apps with a SpaceName. Also, SageMaker Spaces are not currently supported.

This issue duplicates https://github.com/rebuy-de/aws-nuke/issues/1184 to implement the feature in ekristen/aws-nuke

ekristen commented 2 months ago

:tada: This issue has been resolved in version 3.0.0-beta.47 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ekristen commented 2 months ago

Thanks for the issue and the PR! I try and see PRs that folks open up over on rebuy-de/aws-nuke, but sometimes I miss them. I have tooling that does automatic conversions for me that gets the code 95% of the way there. (see migrate tool) but it's not documented.

Happy to help get any other PRs converted or added. I'll add tests for the sagemaker stuff later. One goal I have is to get better testing place such that we can run a test suite when adding new resources in.

npellegrin commented 2 months ago

Thanks for the migrate tool! Will try it with my next contributions 😃

Agree on unit tests, I will implement some with my other PR because it is hard to test Bedrock stuff on real infrastructure without giving a lot of money to AWS.

ekristen commented 2 months ago

Indeed, probably why they haven't been added before. Do you occasionally have bedrock resources that need cleaned up or just trying to be proactive? Ideally we should get some real world usage before getting it in, but if we can get some decent mocks in place I'm ok with that too.

Any additional unit tests you can provide is much appreciated. In the near future I'll likely make it a requirement, but not there yet. Goal is to speed up getting bug fixes and resources in, tests help greatly with that.

npellegrin commented 2 months ago

I have some bedrock resources to remove occasionally. In particular, last week a provisioned throughput for Bedrock earned AWS $400 in 24 hours before we noticed 😭

I'll be able to test this PR with a real infrastructure, at least once to validate everything is properly deleted, but I'll start with mocks it will be easier.

ekristen commented 4 weeks ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: