search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
32 stars 6 forks source link

feat(sagemaker-spaces): add support for Sagemaker Spaces #158

Closed npellegrin closed 2 months ago

npellegrin commented 2 months ago

Closes #157

This PR is a port of https://github.com/rebuy-de/aws-nuke/pull/1197

Output with feature activated

> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID 000000000000 and the alias 'test-account'?
Do you want to continue? Enter account alias to continue.
> test-account

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - would remove
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - would remove
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - would remove
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - would remove
Scan complete: 4 total, 4 nukeable, 0 filtered.

Do you really want to nuke the account with the ID 000000000000 and the alias 'test-account'?
Do you want to continue? Enter account alias to continue.
> test-account

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - triggered remove
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - failed
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - failed
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - triggered remove

Removal requested: 2 waiting, 2 failed, 0 skipped, 0 finished

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - waiting
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - triggered remove
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - failed
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - waiting

Removal requested: 3 waiting, 1 failed, 0 skipped, 0 finished

eu-west-1 - SageMakerApp - default - [AppName: "default", AppType: "JupyterServer", DomainID: "d-fafofydwvicv", SpaceName: "test"] - removed
eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - waiting
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - triggered remove
eu-west-1 - SageMakerUserProfiles - default-1714732293655 - [DomainID: "d-fafofydwvicv", UserProfileName: "default-1714732293655"] - removed

Removal requested: 2 waiting, 0 failed, 0 skipped, 2 finished

eu-west-1 - SageMakerSpace - test - [DomainID: "d-fafofydwvicv", LastModifiedTime: "2024-05-03 10:31:30.218 +0000 UTC", SpaceName: "test", Status: "InService"] - removed
eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - waiting

Removal requested: 1 waiting, 0 failed, 0 skipped, 3 finished

eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - waiting

eu-west-1 - SageMakerDomain - d-fafofydwvicv - [CreationTime: "2024-05-03T10:25:08Z", DomainID: "d-fafofydwvicv"] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 4 finished

Nuke complete: 0 failed, 0 skipped, 4 finished.
ekristen commented 2 months ago

Looks great to me! Thanks for taking the time to get the commit and PR title syntax correct along with commit signing.

ekristen commented 2 months ago

:tada: This PR is included in version 3.0.0-beta.47 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ekristen commented 4 weeks ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: