search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
32 stars 6 forks source link

fix: set config logger #201

Closed darkowlzz closed 1 week ago

darkowlzz commented 1 week ago

Config logger ensures that logs during config loading get printed. https://github.com/ekristen/aws-nuke/pull/198 added logger to Nuke. This adds logger early when loading the config to Config.

This is related to the scenario mentioned in https://github.com/ekristen/libnuke/issues/61#issuecomment-2181633826.

Before:

$ ./aws-nuke run -c nuke-cfg.yaml
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

After:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blacklist' - please use 'blocklist' instead  component=config
WARN[0000] deprecated resource type 'EKSNodegroups' - converting to 'EKSNodegroup'  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.
ekristen commented 1 week ago

:tada: This PR is included in version 3.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: