search

ekristen / aws-nuke

Remove all the resources from an AWS account
https://ekristen.github.io/aws-nuke/
MIT License
259 stars 26 forks source link

feat: add support for backup-report-plan #316

Closed smittnacht closed 2 months ago

smittnacht commented 2 months ago

Added support to list and remove BackupReportPlans https://docs.aws.amazon.com/aws-backup/latest/devguide/API_DeleteReportPlan.html

smittnacht commented 2 months ago

First of all thank you for your contribution! It is much appreciated. I realize that not all these requests are captured in the contributing guide yet, so I appreciate your patience and understanding.

I've commented to give you the opportunity to make the changes if you are willing. If you would prefer not to, I will happily make these changes as an additional commit on your PR and then merge.

Please let me know your preference.

@ekristen thank you for all the detailed review comments ❤️ , I incorporated all of them except the requested removal of arn property. Please let me know if you're fine with this or if you still want this to be changed.

ekristen commented 2 months ago

@smittnacht looks like there's one issue with golangci-lint -- https://github.com/ekristen/aws-nuke/pull/316/files, once you fix that we'll be good to go. If you don't get around to it, I'll fix it before merge tonight.

ekristen commented 2 months ago

:tada: This PR is included in version 3.23.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: