Closed YuriGal closed 6 months ago
@YuriGal thanks, on it.
@YuriGal this is probably why the original nuke doesn't support global filters. How would you like this to behave? Simply warn that it doesn't support it? This could cause filters to be ignored completely. Especially ones defined globally is that acceptable?
Actually I found the problem. You are right the original nuke just allowed it to continue and logged an warning. I will fix this regression and push an update.
Thanks!
This should be fixed on the latest beta release https://github.com/ekristen/aws-nuke/releases/tag/v3.0.0-beta.19
@YuriGal just calling direct attention here so you see it. Thanks for the testing and feedback.
Hi, sorry for the delay, just tried beta.19
- and it works! What's interesting, that list of log errors is much longer now, it shows errors it didn't show before. But it completes successfully.
No worries on delay. Just wanted to make sure you saw the update. Again appreciate the feedback.
There were errors not previously logged or hidden in the past. I rewrote then underlying library and improved logging across the board.
Feel free to share your output sanitized or you can email me direct at erik@ekristen.dev
I can review to see if there's room to improve or if there's specific things you are seeing that look off please let me know.
:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
During run the nuke logs errors about problems I have no control over, for example
If I remember correctly original nuke also detected these errors, but allowed execution to continue, with nuking the resources it could nuke. I believe the fork exits with the status code 1, which fails the entire run.
Is it possible to ignore errors such as mentioned above?