search

ekristen / libnuke

Common Golang Packages for use by the Various Cloud Nuke Tools
MIT License
22 stars 3 forks source link

fix: do not throw error on property not supported, log and continue #39

Closed ekristen closed 6 months ago

ekristen commented 6 months ago

This fixes an parity issue with the original aws nuke code where if a property wasn't supported it would log and continue.

Reference: https://github.com/ekristen/aws-nuke/issues/81

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3efe6a0) 95.19% compared to head (65658ce) 94.97%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== - Coverage 95.19% 94.97% -0.23% ========================================== Files 14 14 Lines 854 855 +1 ========================================== - Hits 813 812 -1 - Misses 26 27 +1 - Partials 15 16 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ekristen commented 6 months ago

:tada: This pull request is included in version 0.10.1 :tada:

The release is available on GitHub release :rocket: