ekristen / libnuke

Common Golang Packages for use by the Various Cloud Nuke Tools
MIT License
22 stars 3 forks source link

feat: changes to support gcp-nuke variant #53

Closed ekristen closed 3 months ago

ekristen commented 3 months ago

This implements a series of changes that allows for the gcp-nuke variant to be completed and follow the same patterns as aws-nuke and azure-nuke before it. Due to how the google golang sdk is written a few additional features needed to be added to allow for proper teardown of clients, renaming of tags to labels, and for filtering to be able to access settings.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.69%. Comparing base (fb5531a) to head (6f7f0ea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== + Coverage 95.62% 97.69% +2.07% ========================================== Files 16 17 +1 Lines 1006 1043 +37 ========================================== + Hits 962 1019 +57 + Misses 26 13 -13 + Partials 18 11 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ekristen commented 3 months ago

:tada: This pull request is included in version 0.15.0 :tada:

The release is available on GitHub release :rocket: