ekristen / libnuke

Common Golang Packages for use by the Various Cloud Nuke Tools
MIT License
26 stars 4 forks source link

fix: account-blocklist deprecation message #65

Closed darkowlzz closed 3 months ago

darkowlzz commented 4 months ago

It logged account-blocklist as account-blacklist before.

For a config with account-blocklist

account-blocklist:
- "999999999999"

Before:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blacklist' - please use 'blocklist' instead  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

After:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blocklist' - please use 'blocklist' instead  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.76%. Comparing base (6bcf973) to head (4946f2b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ======================================= Coverage 97.76% 97.76% ======================================= Files 17 17 Lines 1072 1072 ======================================= Hits 1048 1048 Misses 13 13 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ekristen commented 3 months ago

@darkowlzz can you rebase when you get a minute this will fix the tests so that they pass.

darkowlzz commented 3 months ago

Rebased :slightly_smiling_face:

ekristen commented 3 months ago

:tada: This issue has been resolved in version 0.17.2 :tada:

The release is available on GitHub release :rocket: