search

eksctl-io / eksctl

The official CLI for Amazon EKS
https://eksctl.io
Other
4.88k stars 1.4k forks source link

string constants in the API should match Kubernetes style #1065

Open errordeveloper opened 5 years ago

errordeveloper commented 5 years ago

Part of #888.

We currently have some constants in Kubernetes style, but some aren't.

Namely, we have vpc.nat.gateway where the constants are Disable, Single and HighlyAvailable.

But in nodegroup.ami we use have lower-case.

We also have constants that are defined by AWS, e.g. in cloudWatch.clusterLogging.enableTypes.

Himangini commented 2 years ago

We need to wait for eksctl v1 before proceeding with this change.

SYSHIL commented 1 month ago

Heyy @Himangini @errordeveloper could I be assigned this issue? This is my first one so any pointers will help :)

errordeveloper commented 1 month ago

@SYSHIL I would love to, but I am no longer the maintainer!