Separate tags for nodegroup volumes

eksctl-io / eksctl

The official CLI for Amazon EKS

https://eksctl.io

Other

4.93k stars 1.41k forks source link

Separate tags for nodegroup volumes #3976

Closed artem-nefedov closed 3 years ago

artem-nefedov commented 3 years ago

Our FinOps require us to use different values of the same tag for EC2 instances and EBS volumes. It would be great if eksctl allowed to specify tags for volumes separately. Currently, we instead use our own launch template, but that has some other unwanted implications, and just using native eksctl way to create nodegroup would be preferred.

Callisto13 commented 3 years ago

Thanks for opening this request @artem-nefedov, the team will discuss and get back to you 👍

Random notes for the team if we do implement:

A volumeTags array sounds reasonable. But i really wish we had a ng[].volume object under which we could move the soon-to-be 8 volume config opts. might be worth thinking about
Make sure those who are relying on volume tags being added via ng[].tags do not get broken. Maybe default to adding the current tags if the new tags are nil? 🤷‍♀️

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Himangini commented 3 years ago

closing this due to lack of activity