[Task] Increase Unit test coverage of create cluster - nodegroups

eksctl-io / eksctl

The official CLI for Amazon EKS

https://eksctl.io

Other

4.84k stars 1.4k forks source link

[Task] Increase Unit test coverage of create cluster - nodegroups #5406

Closed Skarlso closed 1 year ago

Skarlso commented 2 years ago

Part of https://github.com/weaveworks/eksctl/issues/5315

The testing of the nodegroups will be a bit finicky because you will have to also start mocking kubernetes client calls to check if the node is available and return the right responses there too.

Luckily, we have a lot of examples doing that already in nodetests and other places.

Skarlso commented 2 years ago

No need to test validation based things
Test a reasonable amount of scenarios ( remember we also have e2e tests )
Not required to add various combinations of node groups types, sizes, etc...
Make sure API calls are covered. That's the most important part.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.