search

eksctl-io / eksctl

The official CLI for Amazon EKS
https://eksctl.io
Other
4.9k stars 1.4k forks source link

[Feature] Support Trn1 Instance Types #5896

Closed dewjam closed 1 year ago

dewjam commented 1 year ago

What feature/behavior/change do you want?

Eksctl currenly launches Trn1 instances types on the EKS Optimized AMI when it should launch using the "Accelerated AMI". Additionally, Trn1 instances require the Neuron Device Plugin DaemonSet.

eksctl should automatically discover the correct AMI for Trn1 instances and automatically install the Neuron Device Plugin when creating new clusters (similar to Inf1 instances).

Why do you want this feature?

Trn1 (Trainium) instance types are now publicly available, but they are difficult to deploy properly via eksctl. This is mostly due to eksctl resolving to Optimized AMI instead of to the Accelerated AMI. I want to streamline the deployment of EKS clusters with Trn1 instances, similar to how it's done with Inf1 instance types.

dewjam commented 1 year ago

I'm testing a fix for this now. Hopefully a PR will be incoming today.

github-actions[bot] commented 1 year ago

Hello dewjam :wave: Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

dewjam commented 1 year ago

I would really like to get this into the v0.118.0 release that is currently in rc. Any thoughts as to whether that's possible? (Assuming I produce a PR today?)

Himangini commented 1 year ago

Closed by https://github.com/weaveworks/eksctl/pull/5906