eksctl-io / eksctl

The official CLI for Amazon EKS
https://eksctl.io
Other
4.92k stars 1.41k forks source link

Enable ASG Metrics Collection for Managed Nodegroups #6224

Closed trombini77 closed 3 months ago

trombini77 commented 1 year ago

What help do you need?

I´m using the eksctl version 0.127.0 and I see in documentation that unmanaged nodegroup has the option to enable the Auto Scaling Group Metrics. Still, it is possible to enable it in managed nodegroups too as is possible to see in the following screens after created a managed nodegroup:

image

image

Here is the unmanaged nodegroup block that enables the feature:

    asgMetricsCollection:
      - granularity: 1Minute
        metrics:
          - GroupMinSize
          - GroupMaxSize
          - GroupDesiredCapacity
          - GroupInServiceInstances
          - GroupPendingInstances
          - GroupStandbyInstances
          - GroupTerminatingInstances
          - GroupTotalInstances

PS. What is possible to see in the screens is a simple flag (turn on/off) without the need to set each metric as unmanaged nodegroup uses. So I believe that this blog post from AWS that shows how to activate it when used aws eks create-nodegroup with --tags ASG_METRICS_COLLLECTION_ENABLED=TRUE to create a managed nodegroup maybe shows the way where the Golang AWS lib can do it, or not ¨\o/¨

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 5 days with no activity.

Himangini commented 1 year ago

@trombini77 thanks for opening this issue. This feature is not currently supported in eksctl for MNGs. We will aim to add this feature for MNGs.

TiberiuGC commented 1 year ago

Hi @trombini77 I did some digging into this and it seems like that flag in the AWS Console for managed nodegroups that you're seeing is currently only editable via autoscaling API. That article on AWS merely presents a handy workaround. As this is not yet part of cloudformation API for managed nodegroups, we'll have to stall this feature until this aws issue is completed.

TiberiuGC commented 3 months ago

@trombini77 - we can probably close this as a result of https://github.com/aws/containers-roadmap/issues/762#issuecomment-2229122915.