eksctl-io / eksctl

The official CLI for Amazon EKS
https://eksctl.io
Other
4.93k stars 1.41k forks source link

[Feature] eksctl update addon "--resolve-conflicts" flag #7293

Closed aws-patrickc closed 1 month ago

aws-patrickc commented 11 months ago

What feature/behavior/change do you want?

Currently eksctl update addon command does not include the "--resolve-conflicts" flag as can be seen on v0.153.0 or later:

 eksctl update addon -h
Upgrade an Addon

Usage: eksctl update addon [flags]

Addon flags:
      --name string                                    Addon name
      --version eksctl utils describe-addon-versions   Add-on version. Use eksctl utils describe-addon-versions to discover a version or set to "latest"
      --service-account-role-arn string                Addon serviceAccountRoleARN
      --force                                          Force migrates an existing self-managed add-on to an EKS managed add-on
      --wait                                           Wait for the addon update to complete

General flags:
  -c, --cluster string       EKS cluster name
  -r, --region string        AWS region. Defaults to the value set in your AWS config (~/.aws/config)
  -f, --config-file string   load configuration from a file (or stdin if set to '-')
      --timeout duration     maximum waiting time for any long-running operation (default 25m0s)

AWS client flags:
  -p, --profile string   AWS credentials profile to use (defaults to the value of the AWS_PROFILE environment variable)

Common flags:
  -C, --color string   toggle colorized logs (valid options: true, false, fabulous) (default "true")
  -d, --dumpLogs       dump logs to disk on failure if set to true
  -h, --help           help for this command
  -v, --verbose int    set log level, use 0 to silence, 4 for debugging and 5 for debugging with AWS debug logging (default 3)

Use 'eksctl update addon [command] --help' for more information about a command.

Ideally we should be able to run something like:

eksctl update addon --name vpc-cni --version 1.8.0 --service-account-role-arn <new-role> --resolve-conflicts Preserve
eksctl update addon --name vpc-cni --version 1.8.0 --service-account-role-arn <new-role> --resolve-conflicts Overwrite

Why do you want this feature?

"eksctl" is used extensively to manage EKS clusters and add-ons, it would be great to have the ability to update the add-on with using eksctl command to preserve or overwrite any conflict as per the AWS CLI

https://docs.aws.amazon.com/cli/latest/reference/eks/update-addon.html

github-actions[bot] commented 11 months ago

Hello aws-patrickc :wave: Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 10 months ago

This issue was closed because it has been stalled for 5 days with no activity.

out-of-band commented 3 months ago

Can this be reopened?

Is there a reason that resolveConflicts is supported as an option in a config file but not from the CLI?

https://eksctl.io/usage/addons/

TiberiuGC commented 3 months ago

@out-of-band

There's a --force flag which essentially implements --resolve-conflicts Overwrite, and the default is None. There's indeed no way of configuring --resolve-conflicts Preserve via CLI flags. The --force flag would ideally be deprecated.

By the time we implemented the resolveConflicts option, we also decided that the general direction for eksctl should be more config file centric. Hence why the option does not exist in the CLI.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue was closed because it has been stalled for 5 days with no activity.